feat(multichain-testing): request body too large #9501
Conversation
|
I manually triggered this job https://github.com/Agoric/agoric-sdk/actions/runs/9501447813/job/26186984429 |
| @@ -46,7 +46,7 @@ make stop | |||
| To setup finish setting up Agoric, also run: | |||
|
|
|||
| ```bash | |||
| make fund-provision-poool | |||
| sed -i -e "s/max_body_bytes = .*/max_body_bytes = 15728640/g" $CHAIN_DIR/config/config.toml | ||
| sed -i -e "s/max_header_bytes = .*/max_header_bytes = 1048576/g" $CHAIN_DIR/config/config.toml | ||
| sed -i -e "s/max_txs_bytes = .*/max_txs_bytes = 1073741824/g" $CHAIN_DIR/config/config.toml | ||
| sed -i -e "s/max_tx_bytes = .*/max_tx_bytes = 15728640/g" $CHAIN_DIR/config/config.toml | ||
| sed -i -e "s/^rpc-max-body-bytes =.*/rpc-max-body-bytes = 15728640/" $CHAIN_DIR/config/app.toml |
There was a problem hiding this comment.
15728640 is 15 mebibytes. For whatever reason, agoric-cli's chain-config.js has 15 megabytes (15e6).
This value shouldn't be any higher. Please reference the agoric-cli value, either by importing or the comment.
| sed -i -e 's/seeds = ".*"/seeds = ""/g' $CHAIN_DIR/config/config.toml | ||
| sed -i -e 's#cors_allowed_origins = \[\]#cors_allowed_origins = \["*"\]#g' $CHAIN_DIR/config/config.toml | ||
|
|
||
| echo "Increase `*_bytes` parameters for MsgInstallBundle" |
There was a problem hiding this comment.
please comment on where these values come from, with enough info that one can cross-check in case either side changes
There was a problem hiding this comment.
Agree. It seems we only have RPC_MAX_BODY_BYTES in agoric-cli's chain-config.js, and nothing for max_header_bytes and max_txs_bytes. I transparently documented how these values were derived, and we can fix-forward if we learn there are better values to use.
Deploying agoric-sdk with
|
| Latest commit: |
b908567
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7fbe45c4.agoric-sdk.pages.dev |
| Branch Preview URL: | https://pc-8896-starship-bundle-inst.agoric-sdk.pages.dev |
0xpatrickdev
force-pushed
the
pc/8896-starship-bundle-install
branch
from
4a8e045
to
2271901
Compare
0xpatrickdev
force-pushed
the
pc/8896-starship-bundle-install
branch
from
2271901
to
b908567
Compare
refs: #8896
Description
The current
stakeIca.contract.jsbundle is ~4.5 MB uncompressed. Any attempted installation resulted in 400 Bad Request: request body too large .This change adjusts
app.tomlandconfig.tomlparams likemax_body_bytes,max_header_bytes,max_txs_bytes,max_tx_bytes, andrpc-max-body-bytes.Security Considerations
Scaling Considerations
The settings may not match other environments, and developers may find their bundles are too large to install if they are only developing against this environment.
Documentation Considerations
The
update-config.shis long and mostly copied fromcosmology-tech/starship. I've added a note about its source and a separate commit for the adjustments made to it.Testing Considerations
Manually tested the parameters in the course of #9042. Expect a test to be checked in with the completion of #9042.
Running the Multichain E2E Testing job and ensuring the
Setup Starship Infrastructurestep passes should give us confidence the overrides are also working in CI.Upgrade Considerations