Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: exofy Orchestrator, RemoteChainFacade #9529

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

turadg
Copy link
Member

@turadg turadg commented Jun 18, 2024

refs: #9281

Description

AsyncFlow requires that everything passing the membrane is durable. This makes the facade objects durable to conform.

Doing so for localChainFacade is deferred so we can get this into master sooner, to aid @erights 's #9521 .

Security Considerations

none

Scaling Considerations

Exo for each chain and each account

Documentation Considerations

none

Testing Considerations

Existing coverage

Upgrade Considerations

none, not yet deployed

Copy link

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8f1c7bd
Status: ✅  Deploy successful!
Preview URL: https://d6d4a5f7.agoric-sdk.pages.dev
Branch Preview URL: https://ta-orch-exos.agoric-sdk.pages.dev

View logs

Copy link
Member

@0xpatrickdev 0xpatrickdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can polish the interface guards later

{
/** @type {Orchestrator['getChain']} */
getChain: async name => {
const agoricChainInfo = await chainHub.getChainInfo('agoric');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these need to all be vow-based?

(I'm hoping not)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they're awaiting at most a remote call to a synchronous method on agoricNames, so they will quiesce in any vat upgrade


const address = await V(icaAccount).getAddress();

const [{ denom: bondDenom }] = remoteChainInfo.stakingTokens || [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment this magic please

@@ -59,12 +61,28 @@ export const provideOrchestration = (
vowTools,
});

const makeCosmosOrchestrationAccount = prepareCosmosOrchestrationAccount(
// XXX what zone?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "FIXME"?

@turadg
Copy link
Member Author

turadg commented Jun 19, 2024

I'll merge now in service of integration and follow up quickly to satisfy requests.

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Jun 19, 2024
@mergify mergify bot merged commit 37ec151 into master Jun 19, 2024
85 checks passed
@mergify mergify bot deleted the ta/orch-exos branch June 19, 2024 14:03
mergify bot added a commit that referenced this pull request Jun 19, 2024
refs: #9281

## Description

AsyncFlow requires that everything passing the membrane is durable. This makes the facade objects durable to conform.

Following #9529 

### Security Considerations
none

### Scaling Considerations
Exo for each chain and each account


### Documentation Considerations
none

### Testing Considerations
Existing coverage


### Upgrade Considerations
not yet deployed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants