refactor(orchestration): simplify example guest code #9586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
0bd6dd0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://22071b22.agoric-sdk.pages.dev |
| Branch Preview URL: | https://markm-simplify-guest-code.agoric-sdk.pages.dev |
0xpatrickdev
approved these changes
Jun 26, 2024
erights
added
automerge:squash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: https://github.com/Agoric/agoric-sdk/pull/9566/files#r1653602477
Description
At https://github.com/Agoric/agoric-sdk/pull/9566/files#r1653602477 @dckc commented on a cleanup that I thought I did and marked as done, but was not done.
Before #9566, the code that would be guest code had several workarounds marked
// XXX when() until membranethat correctly indicated that they should be cleaned up as of #9566, which introduces exactly that membrane.In addition, guest code has no need for
heapVowEsince it doesn't see vows. It should just use the normalE. To keep this distinct, I stopped renaminghostVowEwhere host code needs it in the same file.Security Considerations
none
Scaling Considerations
none
Documentation Considerations
examples are now more like what we want to teach
Testing Considerations
I believe this PR is a pure refactor that should not have any observable effects. Thus, it should not affect any tests. We'll see soon.
Upgrade Considerations
none