Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: patch-package in post-install #9627

Closed
wants to merge 3 commits into from
Closed

build: patch-package in post-install #9627

wants to merge 3 commits into from

Conversation

turadg
Copy link
Member

@turadg turadg commented Jul 1, 2024

UNTIL #451

incidental

Description

When running yarn install anywhere but the SDK root dir, it won't have patch-package in the postinstall so node_modules sometimes fails to have our patches.

For now, add patch-package to every package's postinstall. I also tried preventing install directly from subdirs but I didn't find a way to do that without preventing the root install process as well. This narrower approach is better anyway because the whole need will go away with #451.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

This should be removed in the course of #451. That will remove the patch-package dep so it will be obviously necessary to do this.

Testing Considerations

grep -L patch-package packages/*/package.json comes up empty

Upgrade Considerations

none

@turadg turadg requested review from dtribble and 0xpatrickdev July 1, 2024 14:14
Copy link

cloudflare-workers-and-pages bot commented Jul 1, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 93a4868
Status: ✅  Deploy successful!
Preview URL: https://2129823f.agoric-sdk.pages.dev
Branch Preview URL: https://ta-always-patch.agoric-sdk.pages.dev

View logs

@turadg turadg marked this pull request as draft July 1, 2024 14:21
@turadg
Copy link
Member Author

turadg commented Jul 1, 2024

Now running into re-attempts to patch the same package because patch-package is run multiple times. ds300/patch-package#277 is open and has no progress for years.

I'm closing this to not sink any more time into it. If we want to fix this problem we should just get to Yarn 4 which manages patches itself

@turadg turadg closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant