feat: vote to change swap fee #21

dckc · 2024-03-07T23:33:21Z

refs:

stacked on:

feat: deploy-contract tooling; e2e testing support #16

TODO:

set up a committee
wallet level test of voting, in addition to puppet governance
e2e / on-chain testing

Chris-Hibbert · 2024-03-08T18:22:09Z

Thanks for sharing. This looks like good progress! I didn't see anything to improve.

dckc · 2024-03-08T23:32:01Z

contract/src/platform-goals/start-governed-contract.js

+// import { CONTRACT_ELECTORATE, ParamTypes } from '@agoric/governance';
+const CONTRACT_ELECTORATE = 'Electorate';
+export const ParamTypes = /** @type {const} */ ({
+  INVITATION: 'invitation',


IOU a test to check that these constants are in sync with the imports

many / most are tested now

Why not import constants.js?

The rollup.config.mjs that I'm using for core eval scripts so far doesn't grok inter-package module specifiers.
There's a rollup plugin to do that, but I don't (yet) want to give the impression that this is a general module linking approach; for that, folks should use bundleSource via agoric run.

I did write up docs for this approach:

docs: permissioned contract deployment with tooling documentation#985

Chris-Hibbert

LGTM.

All comments/suggestions are non-blocking

Chris-Hibbert · 2024-03-12T16:18:32Z

contract/src/platform-goals/start-governed-contract.js

+
+/**
+ * cf. packages/inter-protocol/src/econCommitteeCharter.js
+ * TODO: test


Is the TODO obsolete? and the one on line 25?

Chris-Hibbert · 2024-03-12T16:22:05Z

contract/src/platform-goals/start-governed-contract.js

+// import { CONTRACT_ELECTORATE, ParamTypes } from '@agoric/governance';
+const CONTRACT_ELECTORATE = 'Electorate';
+export const ParamTypes = /** @type {const} */ ({
+  INVITATION: 'invitation',


Why not import constants.js?

Chris-Hibbert · 2024-03-12T17:51:50Z

contract/test/test-vote-by-committee.js

+/**
+ * @param {import('ava').ExecutionContext} t
+ * @param {MockWallet} wallet
+ * @param {{ instance: BootstrapPowers['instance']['consume']}} wk


can we have a more evocative name than wk? I haven't come up with an expansion that means anything to me.

well-known is the intended expansion

I'll mull it over...

Chris-Hibbert · 2024-03-12T18:06:56Z

contract/src/swaparoo.proposal.js


 const { Fail } = assert;

 const contractName = 'swaparoo';

+/** @template SF @typedef {import('@agoric/zoe/src/zoeService/utils').StartResult<SF>} StartResult<SF> */


suggestion:

Suggested change

/** @template SF @typedef {import('@agoric/zoe/src/zoeService/utils').StartResult<SF>} StartResult<SF> */

/**

* @template SF

* @typedef {import('@agoric/zoe/src/zoeService/utils').StartResult<SF>} StartResult<SF>

*/

- fix: get namesByAddressAdmin from privateArgs - refactor: subordinate electorate param while writing docs, it became clear that Fee is more interesting

- feat: startMyCommittee - platform-goals/types: governance, vats, Zoe, ERTP types make them available ambiently

- avoid linking to other packages - start committee - test-deploy-tools: test local work-alikes against sdk

- harden - supply puppet electionManager

- puppet-gov: test support - test-swap-wallet: restore to working order with gov - test-vote-fee-change: start governed; change Fee - test-vote-by-committee: vote by committee members with snapshots of offer details - initialize chainTimerService to modern time

samsiegart

I got stumped trying to build out the UI for this, left a couple comments related

samsiegart · 2024-06-10T19:11:53Z

contract/src/platform-goals/start-governed-contract.js

+  const {
+    [committeeName]: { voterAddresses },
+  } = config?.options || {};
+  assert(voterAddresses, 'no voter addresses???');


This assert always passes as long as voteAddresses is an empty object {}. Should we assert that it contains some values?

Well, yes, we should... but I wouldn't be surprised if some tests would need work to meet that constraint.

samsiegart · 2024-06-10T19:18:12Z

contract/src/platform-goals/start-governed-contract.js

+        const depositFacet = E(namesByAddress).lookup(addr, 'depositFacet');
+        await E.when(invitationP, invitation =>
+          E(depositFacet).receive(invitation),
+        ).catch(err => console.error(`failed deposit to ${debugName}`, err));


I tried adding an address through the env variable SWAP_GOV_ADDR in the Makefile which seemed to successfully pipe through to this code, but I'm seeing an error here when deploying the contract:

"nameKey" not found: "agoric1rwwley550k9mmk6uq6mm6z4udrg8kyuyvfszjk"

This is confusing because in the logs I can see that this address has a smart wallet and is opening vaults before it gets to this point. Is there something wrong with namesByAddress in this context?

Maybe you're running on a chain that doesn't have the fix for this one yet? I don't recall what release it's in.

can't send to account by address: namesByAddress is empty agoric-sdk#8113

dckc force-pushed the dc-vote-fee branch 4 times, most recently from 82c5038 to b14cc6a Compare March 8, 2024 09:14

dckc commented Mar 8, 2024

View reviewed changes

dckc mentioned this pull request Mar 9, 2024

docs: permissioned contract deployment with tooling Agoric/documentation#985

Merged

3 tasks

dckc force-pushed the dc-vote-fee branch 2 times, most recently from 3116ff7 to 8154484 Compare March 12, 2024 03:36

dckc changed the title ~~feat: vote to change swap fee (WIP)~~ feat: vote to change swap fee Mar 12, 2024

dckc force-pushed the dc-vote-fee branch 3 times, most recently from ed19e45 to e9f8604 Compare March 12, 2024 05:37

dckc marked this pull request as ready for review March 12, 2024 05:40

dckc mentioned this pull request Mar 12, 2024

contract: swap, pay, vote #9

Closed

3 tasks

dckc requested review from LuqiPan and Chris-Hibbert March 12, 2024 05:51

dckc mentioned this pull request Mar 12, 2024

End runtime imports of types modules Agoric/agoric-sdk#6512

Open

Chris-Hibbert approved these changes Mar 12, 2024

View reviewed changes

dckc force-pushed the dc-e2e-testing branch 4 times, most recently from 9bc9eb9 to 8452d0e Compare March 12, 2024 23:26

dckc force-pushed the dc-vote-fee branch from e9f8604 to 013178e Compare March 13, 2024 13:44

dckc force-pushed the dc-e2e-testing branch from f1b98c8 to 22cbc22 Compare March 15, 2024 23:36

Base automatically changed from dc-e2e-testing to main March 16, 2024 17:34

build: governance resolutions

a9061dc

dckc force-pushed the dc-vote-fee branch from d771fa2 to 9b7ddab Compare March 18, 2024 05:14

dckc added 2 commits March 18, 2024 00:48

build: inter-protocol dep for econCommitteeCharter

1fce454

feat(swaparoo.contract): governed Fee param

33d792b

- fix: get namesByAddressAdmin from privateArgs - refactor: subordinate electorate param while writing docs, it became clear that Fee is more interesting

dckc added 6 commits March 18, 2024 00:48

feat(start-governed-contract): core eval support for governance

1e4c167

- feat: startMyCommittee - platform-goals/types: governance, vats, Zoe, ERTP types make them available ambiently

feat(swaparoo.proposal): start governed

79eab01

- avoid linking to other packages - start committee - test-deploy-tools: test local work-alikes against sdk

fix: patch @agoric/governance for testing

eb05446

- harden - supply puppet electionManager

test: vote-by-committee generated snapshots

441d062

build: lock packages with governance, zone

2f03000

dckc force-pushed the dc-vote-fee branch from f8a3ba8 to 2f03000 Compare March 18, 2024 05:48

dckc merged commit a4d767e into main Mar 18, 2024
1 check passed

dckc mentioned this pull request Mar 18, 2024

ci: add integration test to GitHub Action #24

Merged

samsiegart reviewed Jun 10, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: vote to change swap fee #21

feat: vote to change swap fee #21

dckc commented Mar 7, 2024 •

edited

Loading

Chris-Hibbert commented Mar 8, 2024

dckc Mar 8, 2024 •

edited

Loading

dckc Mar 12, 2024

Chris-Hibbert Mar 12, 2024

dckc Mar 12, 2024

Chris-Hibbert left a comment

Chris-Hibbert Mar 12, 2024

Chris-Hibbert Mar 12, 2024

Chris-Hibbert Mar 12, 2024

dckc Mar 12, 2024

Chris-Hibbert Mar 12, 2024

samsiegart left a comment

samsiegart Jun 10, 2024

dckc Jun 10, 2024

samsiegart Jun 10, 2024

dckc Jun 10, 2024

feat: vote to change swap fee #21

feat: vote to change swap fee #21

Conversation

dckc commented Mar 7, 2024 • edited Loading

Chris-Hibbert commented Mar 8, 2024

dckc Mar 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Chris-Hibbert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samsiegart left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dckc commented Mar 7, 2024 •

edited

Loading

dckc Mar 8, 2024 •

edited

Loading