test(ui): ensure title and connect wallet button render #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
reviewed
Jan 25, 2024
dckc
reviewed
Jan 25, 2024
| "prettier": "^3.2.4", | ||
| "puppeteer": "^21.9.0", |
There was a problem hiding this comment.
hm. Let's not forget that dapp-offer-up is supposed to be simple. I'm a little afraid that readers are going to get overwhelmed by some of this stuff. On the other hand, it's the only sane way to be sure we're not breaking things.
There was a problem hiding this comment.
Good points. In d3b726c I moved the test to /test so it's less prominent. Also have it only running on yarn test:e2e, instead of yarn test.
Maybe this sort of test is best for a react-scripts-esque library that this eventually depends on.
0xpatrickdev
added a commit
that referenced
this pull request
Feb 3, 2024
- there was a regression in #57 that broke `makeAgoricChainStorageWatcher` - it needs to take an apiUrl instead of rpc - `makeAgoricWalletConnection` needs an rpc to work, and an api endpoint, so this change brings it up to date with the new @agoric/rpc changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was added
@testing-library/react, to ensure buttons and header renderpuppeteer, to generate a failing test case foryarn start:uiresults in blank screen #52sesto0.18.8to addressyarn start:uiresults in blank screen #52@agoric/rpcfor esm support (required forvitest)closes #52
closes #53