upgrade to Yarn 4 and clean up some deps #99
Conversation
| @@ -0,0 +1,75 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
Help me understand the workflow around this? How do I know when I should use it?
In general, if I want to yarn add foo, will I need this every time? or every time foo is @agoric/*? How about endo?
There was a problem hiding this comment.
An entry in the scripts key of package.json would make it more discoverable, too. yarn fix-deps?
There was a problem hiding this comment.
for now it's a "if you know you know" kind of tool. I think we need some design discussion around the UX to solve this problem consistently across repos. It should be something you can run with the agoric command or an npx so you don't need the script copied everywhere.
| "resolutions": { | ||
| "ses": "1.3.0", | ||
| "@endo/bundle-source": "2.5.2-upstream-rollup", | ||
| "@endo/captp": "3.1.1", |
There was a problem hiding this comment.
👏 excellent!
Get rid of resolutions-note too, please?
There was a problem hiding this comment.
maybe this looked like the resolutions are gone, but they're just updated. I hope to obviate them eventually but didn't manage yet
| @@ -59,8 +59,10 @@ export const meta = { | |||
| { maxItems: M.bigint() }, | |||
| ), | |||
| }; | |||
| harden(meta); | |||
There was a problem hiding this comment.
is this enforced by this change? if so, cool!
There was a problem hiding this comment.
by the updated Endo lint config
| @@ -14,6 +14,6 @@ | |||
| "author": "Agoric", | |||
| "license": "Apache-2.0", | |||
| "dependencies": { | |||
| "@agoric/cosmic-swingset": "^0.41.3" | |||
| "@agoric/cosmic-swingset": "^0.42.0-u16.2" | |||
There was a problem hiding this comment.
We shouldn't have to maintain _agstate like this. Marking this one as tech debt:
node scripts/update-dependencies.js ses latest node scripts/update-dependencies.js endo latest node scripts/update-dependencies.js agoric agoric-upgrade-16 then copied some resolutions and devDependencies from dapp-offer-up, esp. as of Agoric/dapp-offer-up#99 then yarn && yarn dedupe
Lots of cleanup of dependencies. Principally: