Fix/offer handler test not resolving vow from async-flow #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fails from:
How do we allow this change here? |
turadg
approved these changes
Aug 17, 2024
There was a problem hiding this comment.
Changes LGTM. Before merging please squash the fixup commit. (E.g. git rebase --interactive --autosquash)
Note that #20's title is "contract test to act like UI client". This fixes the one problem described in the issue body but I'm not certain it satisfies the title well enough to close that issue. You know this app much better than I so I leave that to you to decide.
dckc
requested changes
Aug 19, 2024
| @@ -201,6 +230,55 @@ const makeTestContext = async t => { | |||
| }, | |||
| }); | |||
|
|
|||
| const localchain = Far('DummyLocalchain', { | |||
| getChainHub: async () => { | |||
There was a problem hiding this comment.
localchain doesn't have a getChainHub method, does it?
| [ | ||
| 'ubld', | ||
| { | ||
| brand: '$0.Alleged: BLD brand', |
There was a problem hiding this comment.
The value here should be a brand, not a string, right?
Why use a custom namehub implementation? boot-tools.js sets up agoricNames and agoricNamesAdmin in the boostratp promise space.
There was a problem hiding this comment.
seeing this when I try to using agoricNames from boot-tools as you mention here:
orca-contract › orchestrate - osmosis makeAccount and fund returns a ContinuingOfferResult
Rejected promise returned by test. Reason:
Error {
message: 'chain not found:agoric',
}
› makeError (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/ses/src/error/assert.js:349:61)
› eval (.../async-flow/src/convert.js:100:1)
› innerConvert (.../async-flow/src/convert.js:57:8)
› convertRecur (.../async-flow/src/convert.js:26:8)
› Alleged: replayMembrane.convert [as guestToHost] (.../async-flow/src/convert.js:76:1)
› eval (.../async-flow/src/async-flow.js:265:37)and
Error#1: "nameKey" not found: "chain"
at makeError (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/ses/src/error/assert.js:349:61)
at Function.fail (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/ses/src/error/assert.js:481:20)
at NonNullish (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@agoric/internal/src/errors.js:14:10)
at Object.lookup (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@agoric/vats/src/nameHub.js:177:15)
at In "lookup" method of (NameHubKit nameHub) [as lookup] (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@endo/exo/src/exo-tools.js:171:24)
at localApplyMethod (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@endo/eventual-send/src/local.js:126:18)
at Object.applyMethod (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@endo/eventual-send/src/handled-promise.js:455:16)
at dispatchToHandler (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@endo/eventual-send/src/handled-promise.js:156:22)
at doDispatch (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@endo/eventual-send/src/handled-promise.js:486:7)
at win (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@endo/eventual-send/src/handled-promise.js:505:26)
at file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@endo/eventual-send/src/handled-promise.js:523:20digging
Jovonni
force-pushed
the
fix/offer-handler-test
branch
from
d889d4d
to
1694eac
Compare
…mocks for localchain.makeAccount, and vBankAssets. Prettier applied as well
Jovonni
force-pushed
the
fix/offer-handler-test
branch
from
1694eac
to
0a2b68f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20 , good catch @dckc 🚀