Properly reject unauthorized certificates #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only want Airtable.js to connect to servers with authorized SSL certificates, at least by default. Before this change, we weren't doing that. By default, this library would connect to a site with an unauthorized SSL certificate by default. (Confusingly, you could fix this by setting the undocumented `allowUnauthorizedSsl` option to `false`, which is backwards!) This change fixes that. Now the `allowUnauthorizedSsl` option works as expected, and more importantly, we will reject unauthorized certificates by default.
jbbakst
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want Airtable.js to connect to servers with authorized SSL certificates, at least by default.
Before this change, we weren't doing that. By default, this library would connect to a site with an unauthorized SSL certificate by default. (Confusingly, you could fix this by setting the undocumented
allowUnauthorizedSsloption tofalse, which is backwards!)This change fixes that. Now the
allowUnauthorizedSsloption works as expected, and more importantly, we will reject unauthorized certificates by default.