Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend callbackToPromise tests #181

Merged
merged 3 commits into from
Jun 12, 2020
Merged

Extend callbackToPromise tests #181

merged 3 commits into from
Jun 12, 2020

Commits on Jun 11, 2020

  1. Extend callbackToPromise tests 

    - Add 100% coverage
- Test promise reject
- Test callbackArgIndex argument usage
    @rmeritz
    rmeritz committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    54c8d88 View commit details
    Browse the repository at this point in the history

  2. Ensure that promises are correctly tested 

    By returning the result
https://jestjs.io/docs/en/expect.html#resolves
    @rmeritz
    rmeritz committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    20b1ddc View commit details
    Browse the repository at this point in the history

  3. Add more unit tests of callbackToPromise 

    Include unit tests for all cases of the callback index being explicately
set.
    @rmeritz
    rmeritz committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    955616c View commit details
    Browse the repository at this point in the history