Complete tests for lib/record.js
#185
Conversation
test/delete.test.js
Outdated
| .destroy('rec123') | ||
| .then( | ||
| function() { | ||
| throw new Error('Promise unexpectly fufilled.'); |
There was a problem hiding this comment.
Typo: "unexpectly" -> "unexpectedly" (here and below)
test/record.test.js
Outdated
| expect(record.get('foo')).toBeUndefined(); | ||
| expect(record.get('baz')).toEqual('qux'); | ||
|
|
||
| expect(table._base.runAction).toHaveBeenCalledWith( |
There was a problem hiding this comment.
The invocation of _base.runAction doesn't seem particularly important for the caller. A more robust test would involve verifying that an HTTP PUT request is issued. This file sets the precedent, so good on you for finding that and sticking to it! Improving the existing tests is in-scope for our work, but I'll be satisfied if you'd rather address this in a follow-up patch.
There was a problem hiding this comment.
I updated these tests to use the same mocking we use in all other places.
test/delete.test.js
Outdated
| function(err) { | ||
| expect(err.statusCode).toBe(402); | ||
| expect(err.message).toBe('foo bar'); | ||
| done(); |
There was a problem hiding this comment.
The done callback can be omitted when tests return a Promise (here and below)
- Remove unneeded done - Fix spelling issue
And replace with the same mocking we use in all other files
|
@jugglinmike any other comments? |
|
None--this looks good to me! |
No description provided.