Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete lib/query.js tests #186

Merged
merged 7 commits into from
Jun 23, 2020
Merged

Commits on Jun 12, 2020

  1. Add query.js tests

    rmeritz committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    d452cd0 View commit details
    Browse the repository at this point in the history
  2. Istanbul ignore branch

    The else path will never be taken because callbackToPromise which wraps
    this function call will ensure there is always a `done` function.
    rmeritz committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    7e31ec4 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Remove unused if

    callbackToPromise ensures there will always be a `done` function.
    rmeritz committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    eca6195 View commit details
    Browse the repository at this point in the history
  2. Remove test for unused error code path

    There is error checking for a plain object at `lib/table.js:63` and
    `Query` is meant to be a private interface so this code path will never
    be hit.
    rmeritz committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    7149fcc View commit details
    Browse the repository at this point in the history
  3. Remove param validation from Query constructor

    It is not used because validation id done with Query.validateParams in
    `lib/table.js`.
    rmeritz committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    0b5e059 View commit details
    Browse the repository at this point in the history
  4. Remove checking that Query is a plain object

    This checking is done in `lib/table.js` so it isn't needed here.
    rmeritz committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    bb6e0f9 View commit details
    Browse the repository at this point in the history
  5. Remove test for cellFormat

    Move use of cellFormat into select test so that query.test.js can be
    remove.
    rmeritz committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    1323e05 View commit details
    Browse the repository at this point in the history