fix: move offset always, also with invalid processed records #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaakola-aiven
force-pushed
the
jjaakola-aiven-fix-schema-reader-offset-handling-on-invalid-records
branch
2 times, most recently
from
00ba719 to
c4dbc9b
Compare
jjaakola-aiven
force-pushed
the
jjaakola-aiven-fix-schema-reader-offset-handling-on-invalid-records
branch
from
c4dbc9b to
a18f9b5
Compare
keejon
deleted the
jjaakola-aiven-fix-schema-reader-offset-handling-on-invalid-records
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Move the offset in schema reader also when the record key or value is not valid JSON.
The reading can get stuck as offset is not moved.