Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Version int log formatting in schema_reader.py #924

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

nosahama
Copy link
Contributor

@nosahama nosahama commented Jul 25, 2024

About this change - What it does

We use the repr %r formatting instead of int %d for the affected log line and add a test to catch this and act as a reference for testing log statements.

Related traceback

TypeError: %d format: a real number is required, not Version')

@nosahama nosahama requested review from a team as code owners July 25, 2024 10:24
Copy link
Contributor

@eliax1996 eliax1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great! Nice also the test

@eliax1996 eliax1996 enabled auto-merge July 25, 2024 10:35
@eliax1996 eliax1996 disabled auto-merge July 25, 2024 10:36
@eliax1996 eliax1996 enabled auto-merge July 25, 2024 10:44
@eliax1996 eliax1996 merged commit 8c50eb0 into main Jul 25, 2024
9 of 10 checks passed
@eliax1996 eliax1996 deleted the nosahama/EC-393/fix-version-int-log-formatting branch July 25, 2024 11:17
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  karapace
  schema_reader.py
  schema_registry.py
  karapace/backup
  api.py
  safe_writer.py
  karapace/backup/backends
  v2.py
  karapace/kafka
  common.py
  karapace/kafka_rest_apis
  __init__.py
  karapace/protobuf
  syntax_reader.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants