Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable the customization of the kafka properties #927

Merged

Conversation

eliax1996
Copy link
Contributor

About this change - What it does

References: #xxxxx

Why this way

@eliax1996 eliax1996 force-pushed the eliax1996/enable-the-configuration-of-kafka-properties branch 5 times, most recently from 78f9d6d to 73f07f2 Compare July 30, 2024 08:41
Copy link

github-actions bot commented Jul 30, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  karapace
  schema_registry_apis.py 994
  typing.py
  karapace/kafka
  common.py
Project Total  

This report was generated by python-coverage-comment-action

@eliax1996 eliax1996 marked this pull request as ready for review July 30, 2024 11:05
@eliax1996 eliax1996 requested review from a team as code owners July 30, 2024 11:05
@eliax1996 eliax1996 force-pushed the eliax1996/enable-the-configuration-of-kafka-properties branch from 73f07f2 to 71ff3bb Compare July 30, 2024 15:10
Copy link
Contributor

@biggusdonzus biggusdonzus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@biggusdonzus biggusdonzus merged commit ad872d4 into main Sep 13, 2024
10 checks passed
@biggusdonzus biggusdonzus deleted the eliax1996/enable-the-configuration-of-kafka-properties branch September 13, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants