Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests, protobuf: add test on invalid reference schema #962

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

davide-armand
Copy link
Contributor

Given a valid schema, if it references an invalid (corrupted) schema then:

  • Exception CorruptKafkaRecordException should be raised
  • Warning Invalid Protobuf references should be logged

@davide-armand davide-armand marked this pull request as ready for review September 25, 2024 08:45
@davide-armand davide-armand requested review from a team as code owners September 25, 2024 08:45
@davide-armand davide-armand force-pushed the protobuf-references-error-handling-tests branch from 0d9ad85 to 9dc2fa2 Compare September 25, 2024 09:33
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  karapace
  in_memory_database.py
  schema_reader.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@nosahama nosahama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nosahama nosahama merged commit 236d631 into main Sep 25, 2024
10 checks passed
@nosahama nosahama deleted the protobuf-references-error-handling-tests branch September 25, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants