Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: add command line flag to override replication factor in restore command #988

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

biggusdonzus
Copy link
Contributor

@biggusdonzus biggusdonzus commented Oct 31, 2024

This flag is useful if you created a backup of a cluster with N nodes, and now you want to restore on a cluster with less than N nodes.

Also take a look at: https://github.com/aiven/backups-for-apache-kafka/pull/51

@biggusdonzus biggusdonzus force-pushed the fdorlandi-hh-3944-invalide-replication-factor branch 3 times, most recently from 6f66eb3 to ebc23a9 Compare November 4, 2024 12:20
@biggusdonzus biggusdonzus force-pushed the fdorlandi-hh-3944-invalide-replication-factor branch from ebc23a9 to 6336082 Compare November 4, 2024 15:16
Copy link

github-actions bot commented Nov 5, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/karapace/backup
  api.py
  cli.py
Project Total  

This report was generated by python-coverage-comment-action

@biggusdonzus biggusdonzus marked this pull request as ready for review November 5, 2024 13:45
@biggusdonzus biggusdonzus requested review from a team as code owners November 5, 2024 13:45
Copy link
Contributor

@jjaakola-aiven jjaakola-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, same approach that I've done when working locally with 1 node Kafka on Docker and restoring backups from multinode clusters.

Copy link
Contributor

@keejon keejon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@keejon keejon merged commit ba66344 into main Nov 5, 2024
9 checks passed
@keejon keejon deleted the fdorlandi-hh-3944-invalide-replication-factor branch November 5, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants