Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support aarch64 #43

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Jun 13, 2023

support aarch64 arch
fix: #44

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618 yihong0618 requested a review from a team as a code owner June 13, 2023 13:05
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 56.52% and project coverage change: -2.60 ⚠️

Comparison is base (5faf30a) 90.30% compared to head (18928da) 87.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   90.30%   87.71%   -2.60%     
==========================================
  Files          13       13              
  Lines        1991     2002      +11     
==========================================
- Hits         1798     1756      -42     
- Misses        193      246      +53     
Impacted Files Coverage Δ
src/pgtracer/ebpf/unwind.py 85.46% <56.52%> (-4.03%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rdunklau
Copy link
Collaborator

Sorry for some reason I did not see the notification for this PR.

Thank you for the work. I will see how to add this new arch to the CI and merge it once done.

@yihong0618
Copy link
Contributor Author

yihong0618 commented Aug 17, 2023

Sorry for some reason I did not see the notification for this PR.

Thank you for the work. I will see how to add this new arch to the CI and merge it once done.

there's no aarch64 in Actions, seems we need use something like QEMU
@rdunklau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not support aarch64 arch for now
2 participants