Implementation for new SMT ExtractTopicFromValueSchema and tests #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaakola-aiven
requested changes
Jun 7, 2023
There was a problem hiding this comment.
Thank you for the contribution @mikaka-paf.
I did a static pass of the code now, some notes and change requests commented.
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java
Outdated
Show resolved
Hide resolved
src/test/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaTest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java
Outdated
Show resolved
Hide resolved
...gration-test/java/io/aiven/kafka/connect/transforms/TopicFromValueSchemaIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java
Outdated
Show resolved
Hide resolved
jjaakola-aiven
requested changes
Jun 8, 2023
src/integration-test/java/io/aiven/kafka/connect/transforms/IntegrationTest.java
Outdated
Show resolved
Hide resolved
jjaakola-aiven
previously approved these changes
Jun 8, 2023
mikaka-paf
force-pushed
the
Initial-test-with-SMT-ExtractTopicFromEventType
branch
from
673f9c3
to
06d5c1d
Compare
|
@mikaka-paf Could you still fix the typo from commit message to |
mikaka-paf
force-pushed
the
Initial-test-with-SMT-ExtractTopicFromEventType
branch
from
06d5c1d
to
08c0396
Compare
AnatolyPopov
requested changes
Jun 8, 2023
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java
Outdated
Show resolved
Hide resolved
AnatolyPopov
requested changes
Jun 9, 2023
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java
Outdated
Show resolved
Hide resolved
src/test/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaTest.java
Outdated
Show resolved
Hide resolved
AnatolyPopov
reviewed
Jun 9, 2023
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java
Outdated
Show resolved
Hide resolved
AnatolyPopov
reviewed
Jun 9, 2023
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java
Outdated
Show resolved
Hide resolved
AnatolyPopov
requested changes
Jun 9, 2023
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromSchemaName.java
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromSchemaName.java
Outdated
Show resolved
Hide resolved
AnatolyPopov
approved these changes
Jun 11, 2023
There was a problem hiding this comment.
Thanks fro addressing all the comments @mikaka-paf! Looks good to me know.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for new SMT ExtractTopicFromValueSchema and tests