Add toggle display secondary subtitle in selected text #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the customizations I made to mpvacious more than a year ago, it was quite useful for my mining workflow.
The main issue it addresses is that JP subs and EN are not always the same length even if their timings are synced. So what I've found happens frequently is you can collect all relevant JP subs and create an Anki card but the EN subs might be incomplete because the last line has not shown up (and therefore collected) yet. Adding a toggle to display the EN subs solves this issue as you can see exactly which JP and EN lines were collected. The toggle is set to false by default as obviously some people might not care to see the secondary subs ever.
I'm not sure about the exact hotkey to use or the best way to display this toggle.
Demo that shows toggling on and off. It also displays the issue where you can mine the JP sub prematurely before the EN sub is also collected. The 200,000 yen line in English appears a bit later:
togglesecondsiddemo.mp4