Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle display secondary subtitle in selected text #119

Merged
merged 4 commits into from Jan 29, 2024
Merged

Add toggle display secondary subtitle in selected text #119

merged 4 commits into from Jan 29, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 14, 2024

This is one of the customizations I made to mpvacious more than a year ago, it was quite useful for my mining workflow.

The main issue it addresses is that JP subs and EN are not always the same length even if their timings are synced. So what I've found happens frequently is you can collect all relevant JP subs and create an Anki card but the EN subs might be incomplete because the last line has not shown up (and therefore collected) yet. Adding a toggle to display the EN subs solves this issue as you can see exactly which JP and EN lines were collected. The toggle is set to false by default as obviously some people might not care to see the secondary subs ever.

I'm not sure about the exact hotkey to use or the best way to display this toggle.

Demo that shows toggling on and off. It also displays the issue where you can mine the JP sub prematurely before the EN sub is also collected. The 200,000 yen line in English appears a bit later:

togglesecondsiddemo.mp4

@tatsumoto-ren
Copy link
Member

I'm not sure how to feel about this because at AJATT we want to discourage people from reading Eng subs as much as possible. Ideally they shouldn't be available at all, and the learners shouldn't have English text on their cards.

https://tatsumoto.neocities.org/blog/en-and-ja-subs-at-the-same-time

But you can do it like this to avoid adding a new config toggle.

  • if secondary_field is empty (in the config file) then the user doesn't want English on the card, so don't show the English to them.
  • otherwise show the English text (and add it to the card).

@tatsumoto-ren tatsumoto-ren merged commit 85affbc into Ajatt-Tools:master Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants