Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support ** and __ in the new version placeholder #62

Merged
merged 1 commit into from
Apr 30, 2021
Merged

feat: support ** and __ in the new version placeholder #62

merged 1 commit into from
Apr 30, 2021

Conversation

AlCalzone
Copy link
Owner

fixes: #52

@AlCalzone AlCalzone merged commit d4f11d8 into master Apr 30, 2021
@AlCalzone AlCalzone deleted the update-placeholder branch April 30, 2021 08:06
UncleSamSwiss
UncleSamSwiss reviewed Apr 30, 2021
View reviewed changes
Copy link
Contributor

@UncleSamSwiss UncleSamSwiss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good, but I would suggest to start adding unit tests (or integration tests) as soon as possible. Because now the number of ways to use the tool has just jumped from 2 to 4 (readme vs Changelog & ** vs __)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UncleSamSwiss UncleSamSwiss UncleSamSwiss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support star for placeholders
2 participants
@AlCalzone @UncleSamSwiss