Fix regression WHERE (not) in (4.2.0) #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add pattern cache when using like (building RegEx is expensive) - Optimize when having lots of values in a (NOT) IN statement, using JS Set - Remove RegEx checking for DATE function - When using NOW, just return the date (not sure why a date is translated to a string and then to a date again)
- Add AST cache
- Adjust or skip unit tests
- Remove cache property
- Fix LIKE unit tests by not using toUpperCase() anymore; use same code as before, but now with a patternCache
- Always use SET, remove old code
- Made returning Date objects configurable as option, to remain backwards compatible - Added unit test for Date objects in relevant test cases
- Fix using new String in IN statement - Add new test cases for using plain string literals in both IN and NOT IN
- Fix regression when using IN / NOT IN - Using refs didn't work anymore - Dropped set cache, as it's not really needed unless the same queries are performed often - Added unit test to guard behavior
# Conflicts: # src/50expression.js
paulrutter
changed the title
|
@mathiasrw Some regression introduced in 4.2.0, this PR fixes it. See the new unit test. |
|
Thank you so much for acting on this rapidly. |
mathiasrw
reviewed
Nov 12, 2023
|
Released as part of 4.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1829.