Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add emphasis text color #83 #87

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Conversation

leeejune
Copy link
Contributor

@leeejune leeejune commented Sep 28, 2022

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Added midnight-400 as a text color token for emphasis. This is to support designers who have been using/want to use a different header color.

Fixes: #83

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@leeejune leeejune self-assigned this Sep 28, 2022
@leeejune leeejune linked an issue Oct 4, 2022 that may be closed by this pull request
leeejune and others added 2 commits October 6, 2022 08:16
Changes to be committed:
modified:   src/color/text.json
Changes to be committed:
new file:   .github/CODEOWNERS
@blackfalcon blackfalcon force-pushed the junelee/addTextColor/#83 branch from 1b35b1b to 51a9733 Compare October 6, 2022 15:20
Comment on lines +93 to +110
},
"emphasis": {
"onLight": {
"value": "{color.brand.midnight.400.value}",
"public": true,
"onLight": true,
"usage": "Emphasized text color on light backgrounds",
"wcag": "n/a",
"deprecated": false
},
"onDark": {
"value": "{color.brand.midnight.100.value}",
"public": true,
"onDark": true,
"usage": "Emphasized text color on dark backgrounds",
"wcag": "n/a",
"deprecated": false
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

Screen Shot 2022-10-06 at 8 18 22 AM

@blackfalcon blackfalcon merged commit c48d642 into master Oct 6, 2022
@blackfalcon blackfalcon deleted the junelee/addTextColor/#83 branch October 6, 2022 15:21
@AuroDesignSystem
Copy link
Collaborator

🎉 This PR is included in version 3.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AuroDesignSystem AuroDesignSystem added the released Completed work has been released label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design tokens released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add accent text color token
3 participants