Accessibility focus-visible default halo #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blackfalcon Would this work? |
|
I am recommending that we DO NOT use border-radius. In many cases this halo tightly surrounds some content and with rounded corners, it is too close to the content. 
|
blackfalcon
force-pushed
the
dsande/focus
branch
2 times, most recently
from
05d732f to
10988d7
Compare
@blackfalcon Sure, then the blue border should work. |
blackfalcon
force-pushed
the
dsande/focus
branch
from
10988d7 to
e8a10bc
Compare
blackfalcon
added a commit
that referenced
this pull request
Feb 29, 2024
This commit adds a new focus-visible feature to WCSS. At the same time, the legacy focus-visible solution has been deprecated. The use of the Sass variable to change output was not well adopted. In order NOT to force this update into all UI scenarios as there may be local code to address this in some cases, this feature has been added as an OPT-IN feature. See inline documentation for info related to update and install instructions. Changes to be committed: modified: README.md modified: src/_core.scss new file: src/_focus-visible.scss new file: src/bundled/essentials+fv.scss
blackfalcon
force-pushed
the
dsande/focus
branch
from
e8a10bc to
5c4d706
Compare
This commit adds a new focus-visible feature to WCSS. At the same time, the legacy focus-visible solution has been deprecated. The use of the Sass variable to change output was not well adopted. In order NOT to force this update into all UI scenarios as there may be local code to address this in some cases, this feature has been added as an OPT-IN feature. See inline documentation for info related to update and install instructions. Changes to be committed: modified: README.md modified: src/_core.scss new file: src/_focus-visible.scss new file: src/bundled/essentials+fv.scss modified: src/elementDemoStyles/elementDemoStyles.scss
Changes to be committed: modified: tests/styleTest.scss
Changes to be committed: modified: package.json
Changes to be committed: modified: docs/index.html
blackfalcon
force-pushed
the
dsande/focus
branch
from
5c4d706 to
7927789
Compare
blackfalcon
changed the title
leeejune
previously approved these changes
Feb 29, 2024
Changes to be committed: modified: package-lock.json modified: package.json
Changes to be committed: modified: README.md
Comment on lines
-107
to
-108
|
|
||
| WCSS fully supports idiomatic CSS, be sure to review the [auro docs site](https://auro.alaskaair.com/webcorestylesheets/idiomatic-css) for more information. |
There was a problem hiding this comment.
Does that mean this needs to be removed?
There was a problem hiding this comment.
Moved the conversation about the removal of this content to an internal channel. A larger discussion that has little impact on this PR. We can easily put this back if the resolution calls fro that action.
jason-capsule42
approved these changes
Feb 29, 2024
blackfalcon
added a commit
that referenced
this pull request
Mar 5, 2024
This commit adds a new focus-visible feature to WCSS. At the same time, the legacy focus-visible solution has been deprecated. The use of the Sass variable to change output was not well adopted. In order NOT to force this update into all UI scenarios as there may be local code to address this in some cases, this feature has been added as an OPT-IN feature. See inline documentation for info related to update and install instructions. Changes to be committed: modified: README.md modified: src/_core.scss new file: src/_focus-visible.scss new file: src/bundled/essentials+fv.scss modified: src/elementDemoStyles/elementDemoStyles.scss
blackfalcon
pushed a commit
that referenced
this pull request
Mar 5, 2024
# [5.1.0](v5.0.8...v5.1.0) (2024-03-05) ### Features * a11y focus-visible default halo [#183](#183) ([3952acd](3952acd))
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #182
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
This PR adds a new focus-visible feature to WCSS. At the same time,
the legacy focus-visible solution has been deprecated.
The use of the Sass variable to change output was not well adopted.
In order NOT to force this update into all UI scenarios as there may be
local code to address this in some cases, this feature has been added as
an OPT-IN feature.
See inline documentation for info related to update and install
instructions.
Changes to be committed:
modified: README.md
modified: src/_core.scss
new file: src/_focus-visible.scss
new file: src/bundled/essentials+fv.scss
modified: src/elementDemoStyles/elementDemoStyles.scss
See demo: https://auro-a11y-tab-fix.surge.sh/
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team