Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move theming support from Beta to Main #199

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Move theming support from Beta to Main #199

merged 3 commits into from
Sep 30, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Sep 18, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #197

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Update color tokens to use new design tokens
  • Remove all deprecated code

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Move theming support from beta to main by introducing new design tokens for color theming. Remove all deprecated code, including old breakpoint mixins, and update documentation and tests to reflect these changes.

New Features:

  • Introduce new design tokens for color theming, moving theming support from beta to main.

Enhancements:

  • Replace deprecated breakpoint mixins with a more flexible auro_breakpoint mixin.
  • Update color variables to align with new design tokens, enhancing consistency across the UI.

Documentation:

  • Update documentation to reflect the removal of deprecated code and the introduction of new design tokens.

Tests:

  • Adjust tests to accommodate changes in color values and breakpoint mixins.

jordanjones243 and others added 3 commits August 26, 2024 10:37
BREAKING CHANGE: all previously deprecated code has been removed and will no longer be supported
# [6.0.0-beta.1](v5.1.2...v6.0.0-beta.1) (2024-08-26)

### Features

* **color:** use new design tokens for color theme support [#197](#197) ([704ecad](704ecad))

### BREAKING CHANGES

* **color:** all previously deprecated code has been removed and will no longer be supported
@jordanjones243 jordanjones243 self-assigned this Sep 18, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner September 18, 2024 20:38
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jordanjones243
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

sourcery-ai bot commented Sep 18, 2024

Reviewer's Guide by Sourcery

This pull request updates the theming support in the Alaska Airlines WebCoreStyleSheets project, moving it from Beta to Main. The changes primarily involve updating color token references to use new design tokens, removing deprecated code, and adjusting some breakpoint mixins.

File-Level Changes

Change Details Files
Updated color token references to use new design tokens
  • Replaced old color variable names with new ones (e.g., --ds-color-ui-default-default to --ds-color-text-ui-default-default)
  • Updated background color references to use new container color tokens
  • Changed border color references to use updated UI-specific tokens
src/_essentials.scss
src/utilityMixins/_anchor-roleButton.scss
src/utilityMixins/_anchor-roleTab.scss
src/componentSupport/_table.scss
src/_blockquote.scss
src/_focus-visible.scss
src/elementDemoStyles/elementDemoStyles.scss
Removed deprecated code and updated breakpoint mixins
  • Removed the deprecated global selector and focus-related code in _core.scss
  • Deleted deprecated breakpoint mixins (auro_breakpoint--lg, auro_breakpoint--md, auro_breakpoint--sm)
  • Updated usage of breakpoint mixins to use the new auro_breakpoint mixin with explicit parameters
src/_core.scss
src/_breakpoints.scss
src/_headings.scss
src/componentSupport/_containedButtons.scss
src/componentSupport/_tablist.scss
Removed deprecated grid class
  • Deleted the .grid class and its associated styles
  • Removed references to the deprecated grid class
src/_grids.scss
Updated documentation and version number
  • Incremented version number to 5.1.2 in documentation
  • Updated changelog to reflect breaking changes and new features
  • Adjusted examples and descriptions in documentation to reflect new color token usage
docs/index.html
CHANGELOG.md

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@jordanjones243 jordanjones243 linked an issue Sep 18, 2024 that may be closed by this pull request
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

CHANGELOG.md Show resolved Hide resolved
@jason-capsule42 jason-capsule42 merged commit 5ec449e into master Sep 30, 2024
1 check was pending
@jason-capsule42 jason-capsule42 deleted the beta branch September 30, 2024 22:26
@blackfalcon
Copy link
Member

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auro-wcss: update for latest design tokens refactor
5 participants