Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove label colors from github settings #200

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Oct 1, 2024

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Remove label color settings from the GitHub configuration file to streamline label management and reduce unnecessary complexity.

Enhancements:

  • Remove color attributes from GitHub label settings to simplify label configuration.

BREAKING CHANGE: force major release for last beta merge
@jason-capsule42 jason-capsule42 requested a review from a team as a code owner October 1, 2024 19:45
Copy link

sourcery-ai bot commented Oct 1, 2024

Reviewer's Guide by Sourcery

This pull request removes color definitions for labels in the GitHub settings file. It's a performance-related change that simplifies the label configuration.

Simplified GitHub Label Configuration

graph TD;
    A[auro-wcss] -->|Removed color| B[duplicate];
    B -->|Removed color| C[not-reviewed];
    C -->|Removed color| D[good first issue];
    D -->|Removed color| E[help wanted];
    E -->|Removed color| F[released];
    F -->|Removed color| G[Status: Work In Progress];
    G -->|Removed color| H[Status: Review Needed];
    H -->|Removed color| I[Status: Complete];
    I -->|Removed color| J[Status: Blocked];
    J -->|Removed color| K[Abandoned];
    K -->|Removed color| L[Type: Bug];
    L -->|Removed color| M[Type: Feature];
    M -->|Removed color| N[Type: Design];
    N -->|Removed color| O[Type: Content];
    O -->|Removed color| P[Type: Refactoring];
    P -->|Removed color| Q[Type: Documentation];
    Q -->|Removed color| R[Type: CI];
    R -->|Removed color| S[Type: Perf];
    S -->|Removed color| T[Question];
    T -->|Removed color| U[Type: Dependencies];
    U -->|Removed color| V[Type: UI Update];
Loading

File-Level Changes

Change Details Files
Removed color definitions for all labels in the GitHub settings
  • Deleted 'color' property from all label definitions
  • Kept label names, descriptions, and aliases intact
  • Affected various label types including status, type, and process labels
.github/settings.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@jason-capsule42 jason-capsule42 linked an issue Oct 1, 2024 that may be closed by this pull request
@jason-capsule42 jason-capsule42 self-assigned this Oct 1, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you please provide more context on why this is considered a breaking change that requires a major version bump? The removal of label colors doesn't seem to warrant this level of version impact.
  • What's the motivation behind removing the color definitions for the labels? It would be helpful to understand how this change aligns with the project's goals or improves the workflow.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

.github/settings.yml Show resolved Hide resolved
@jason-capsule42 jason-capsule42 merged commit 4132d2a into master Oct 1, 2024
4 checks passed
@jason-capsule42 jason-capsule42 deleted the jbaker/stripLabelColors branch October 1, 2024 19:52
@blackfalcon
Copy link
Member

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WCSS support for themes
3 participants