-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: remove label colors from github settings #200
Conversation
BREAKING CHANGE: force major release for last beta merge
Reviewer's Guide by SourceryThis pull request removes color definitions for labels in the GitHub settings file. It's a performance-related change that simplifies the label configuration. Simplified GitHub Label Configurationgraph TD;
A[auro-wcss] -->|Removed color| B[duplicate];
B -->|Removed color| C[not-reviewed];
C -->|Removed color| D[good first issue];
D -->|Removed color| E[help wanted];
E -->|Removed color| F[released];
F -->|Removed color| G[Status: Work In Progress];
G -->|Removed color| H[Status: Review Needed];
H -->|Removed color| I[Status: Complete];
I -->|Removed color| J[Status: Blocked];
J -->|Removed color| K[Abandoned];
K -->|Removed color| L[Type: Bug];
L -->|Removed color| M[Type: Feature];
M -->|Removed color| N[Type: Design];
N -->|Removed color| O[Type: Content];
O -->|Removed color| P[Type: Refactoring];
P -->|Removed color| Q[Type: Documentation];
Q -->|Removed color| R[Type: CI];
R -->|Removed color| S[Type: Perf];
S -->|Removed color| T[Question];
T -->|Removed color| U[Type: Dependencies];
U -->|Removed color| V[Type: UI Update];
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you please provide more context on why this is considered a breaking change that requires a major version bump? The removal of label colors doesn't seem to warrant this level of version impact.
- What's the motivation behind removing the color definitions for the labels? It would be helpful to understand how this change aligns with the project's goals or improves the workflow.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Remove label color settings from the GitHub configuration file to streamline label management and reduce unnecessary complexity.
Enhancements: