Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-avatar: fallback image sometimes does not work (intermittent) #28

Closed
MattSidor opened this issue Nov 29, 2022 · 0 comments · Fixed by #27
Closed

auro-avatar: fallback image sometimes does not work (intermittent) #28

MattSidor opened this issue Nov 29, 2022 · 0 comments · Fixed by #27
Assignees
@MattSidor
Labels
Type: Bug Bug or Bug fixes

Comments

@MattSidor
Copy link
Contributor

MattSidor commented Nov 29, 2022 •
edited
Loading

Describe the bug

The fallback image sometimes does not work.

To Reproduce

Steps to reproduce the behavior:

  1. Use an invalid code attribute, such as <auro-avatar code="INVALID"></auro-avatar>
  2. Note broken image sometimes loads instead of fallback

Expected behavior

A fallback image of clouds (https://resource.alaskaair.net/-/media/Images/common-assets/destinations/800x800/partner)

Screenshots

From the docs page (http://auro.alaskaair.com/components/auro/avatar):

Screen Shot 2022-11-28 at 9 06 37 PM

Additional context

This problem appears to be intermittent -- sometimes it loads, sometimes it does not.

When it is not working, it is because the CDN (resource.alaskaair.net) returns a 403 error status code for the invalid URL, but the component only checks for 404.
@MattSidor MattSidor added Type: Bug Bug or Bug fixes not-reviewed Issue has not been reviewed by Auro team members labels Nov 29, 2022
MattSidor pushed a commit that referenced this issue Nov 29, 2022
fix(fallback): check for 403 http status code for fallback image #28
f9775e2
MattSidor pushed a commit that referenced this issue Nov 29, 2022
fix(fallback): check for 403 http status code for fallback image #28
71415ed
@MattSidor MattSidor mentioned this issue Nov 29, 2022
Merged
3 tasks
@blackfalcon blackfalcon linked a pull request Nov 30, 2022 that will close this issue
fix: enable reflect on 'type' attribute #26, check for http 403 status code #28 #27
Merged
3 tasks
@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Nov 30, 2022
blackfalcon pushed a commit that referenced this issue Nov 30, 2022
@blackfalcon
fix(fallback): check for 403 http status code for fallback image #28
81e724e
blackfalcon pushed a commit that referenced this issue Dec 1, 2022
@semantic-release-bot
chore(release): 4.2.1 [skip ci]
c5c6a9f 
## [4.2.1](v4.2.0...v4.2.1) (2022-12-01)

### Bug Fixes

* **fallback:** check for 403 http status code for fallback image [#28](#28) ([81e724e](81e724e))
* **properties:** enable reflect on 'type' attribute [#26](#26) ([03435d2](03435d2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattSidor MattSidor

Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
2 participants
@blackfalcon @MattSidor