-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jbaker/beta release #131
Jbaker/beta release #131
Conversation
Somehow, this repo was missing a lot of the new build scripts, and was not able to generate a new README or other docs. This commit adds those sans the `build:version` script as we did not need that for this repo. Changes to be committed: modified: demo/api.html modified: package.json
# [2.8.0-beta.2](v2.8.0-beta.1...v2.8.0-beta.2) (2024-08-19) ### Bug Fixes * **#123:** rerouted departure and arrival stations display as expected now ([73eb66c](73eb66c)), closes [#123](#123) ### Performance Improvements * update deps and refactor scripts to use auro-library versions ([52683c2](52683c2))
BREAKING CHANGE: trigger major release for color theme support #121
# [3.0.0-beta.1](v2.8.0-beta.2...v3.0.0-beta.1) (2024-10-03) ### Features * add custom registered auro-datetime ([33a189b](33a189b)) * add tag name as attribute when custom registered ([26808eb](26808eb)) ### Performance Improvements * refactor custom component registration config ([1f3e0de](1f3e0de)) * remove github label colors ([b5187c0](b5187c0)) * update dependencies ([2de3a30](2de3a30)) ### BREAKING CHANGES * trigger major release for color theme support #121
|
Reviewer's Guide by SourceryThis pull request implements several changes to the auro-flight component, including code refactoring, styling updates, and dependency management improvements. The changes aim to enhance the component's maintainability, performance, and adherence to design standards. Class diagram for AuroFlight and AuroFlightMain componentsclassDiagram
class AuroFlight {
+AuroLibraryRuntimeUtils runtimeUtils
+firstUpdated()
+static get properties()
+static get styles()
}
class AuroFlightMain {
+AuroDependencyVersioning versioning
+String datetimeTag
+static get styles()
+constructor()
}
AuroFlightMain --> AuroFlight : uses
AuroFlightMain --> AuroDependencyVersioning
AuroFlight --> AuroLibraryRuntimeUtils
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Hard-coded version number found. (link)
Overall Comments:
- The refactoring and modularization of styles improve maintainability, but ensure that documentation generation is still handled appropriately after removing scripts like generateDocs.mjs.
- Consider adding comments explaining the purpose of new files like datetimeVersion.js and the rationale behind splitting color styles into separate files.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🔴 Security: 1 blocking issue
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: # (issue, if applicable)
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Release a beta version of the auro-flight component with theme support, refactor CSS for better maintainability, and update documentation and tests to reflect these changes.
New Features:
Enhancements:
Documentation:
Tests:
Chores: