-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MULTI-GITTER PR: migration github-config-and-gitignore-changes #141
base: main
Are you sure you want to change the base?
Conversation
…thub workflow files
Reviewer's Guide by SourceryThis PR updates various GitHub configuration files and templates to improve repository management and contribution processes. The changes focus on standardizing issue templates, updating documentation, and refining repository settings. Class diagram for GitHub configuration changesclassDiagram
class Repository {
+String homepage
+String[] topics
+Boolean has_issues
+Boolean allow_rebase_merge
}
class Team {
+String name
+String permission
}
class Label {
+String name
+String color
+String description
+String[] aliases
}
Repository "1" -- "*" Team : manages
Repository "1" -- "*" Label : uses
note for Repository "Updated homepage URL and topics list"
note for Team "Added new team permissions"
note for Label "Added color attribute to labels"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmenner - I've reviewed your changes - here's some feedback:
Overall Comments:
- This PR combines multiple unrelated changes (contributing docs, GitHub settings, issue templates etc). Please split into separate focused PRs for each area of change to facilitate better review and maintenance.
- Please add context in the PR description explaining the motivation for key changes like removing the repository description from settings.yml
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Revise GitHub configuration files to improve contribution guidelines, issue templates, and CI workflows. Enhance documentation for contributors and streamline the process for submitting issues and pull requests. Introduce a new workflow for deploying demo environments.
CI:
Documentation: