Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-menu: multiselect #199

Closed
braven112 opened this issue Apr 17, 2024 · 1 comment
Closed

auro-menu: multiselect #199

braven112 opened this issue Apr 17, 2024 · 1 comment
Assignees
@fajar-apri-alaska @chrisfalaska
Labels
auro-menu Type: Feature New Feature

Comments

@braven112
Copy link
Member

braven112 commented Apr 17, 2024 •
edited by Patrick-Daly-AA
Loading

Is your feature request related to a problem? Please describe.

As a business I want to give users the ability to select multiple options from menu items
So that users can select multiple options in the UI.

Blueprint:
https://www.figma.com/file/yMshXAiKZrkLDdiX8N4GKQ/Multi-Select-Combo-Box?type=design&node-id=114-3745&mode=design&t=R007FIBn8d6HGOOY-11

Describe the solution you'd like

A menu with checkboxes so users can select as many as they want.

Describe alternatives you've considered

No response

Additional context

No response

Exit criteria

  1. Auro-menu feature matches the blueprint.
  2. Create refinement meeting team on next step to align on implementation of next step.
  3. As an outcome of the refiement a new issue is created to implement this as either <auro-multiselect> or <auro-combobox multiselect>
  4. When Menu is Multiselect, value is an Array containing all selected menu options.
@braven112 braven112 added Type: Feature New Feature auro-menu not-reviewed Issue has not been reviewed by Auro team members labels Apr 17, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label Apr 18, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Apr 18, 2024
fajar-apri-alaska added a commit that referenced this issue May 14, 2024
@fajar-apri-alaska
feat: add multiple selection feature #199
0943893 
- add test case for multiple selection
- add api docs
- add example for multiple selection
@fajar-apri-alaska fajar-apri-alaska mentioned this issue May 14, 2024
Closed
6 tasks
@fajar-apri-alaska fajar-apri-alaska linked a pull request May 14, 2024 that will close this issue
Feature: Multiple selection #202
Closed
6 tasks
fajar-apri-alaska added a commit that referenced this issue May 15, 2024
@fajar-apri-alaska
feat: add multiple selection feature #199
7729eec 
- add test case for multiple selection
- add api docs
- add example for multiple selection
blackfalcon added a commit that referenced this issue May 20, 2024
@blackfalcon
feat(multi-select): add support for selection option #199
4c13731 
The core of this commit is updating the ability of the element to know
the difference between the default single-select and the multi-select
option. With the multi-select options selected, the value of the menu
selections will be kept in an array versus a single string.

Changes to be committed:
modified:   src/auro-menu.js
modified:   src/style-base.scss
modified:   src/style-menuoption.scss
fajar-apri-alaska pushed a commit that referenced this issue Aug 22, 2024
@blackfalcon @fajar-apri-alaska
feat(multi-select): add support for selection option #199
bed46ab 
The core of this commit is updating the ability of the element to know
the difference between the default single-select and the multi-select
option. With the multi-select options selected, the value of the menu
selections will be kept in an array versus a single string.

Changes to be committed:
modified:   src/auro-menu.js
modified:   src/style-base.scss
modified:   src/style-menuoption.scss
@chrisfalaska chrisfalaska self-assigned this Dec 16, 2024
chrisfalaska pushed a commit that referenced this issue Dec 17, 2024
@blackfalcon
feat(multi-select): add support for selection option #199
0467e45 
The core of this commit is updating the ability of the element to know
the difference between the default single-select and the multi-select
option. With the multi-select options selected, the value of the menu
selections will be kept in an array versus a single string.

Changes to be committed:
modified:   src/auro-menu.js
modified:   src/style-base.scss
modified:   src/style-menuoption.scss
This was referenced Dec 17, 2024
Open
Draft
@chrisfalaska
Copy link

This work has been moved to auro-formkit and will be completed in AlaskaAirlines/auro-formkit#123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fajar-apri-alaska fajar-apri-alaska

@chrisfalaska chrisfalaska

Labels
auro-menu Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: Multiple selection AlaskaAirlines/auro-menu
4 participants
@braven112 @fajar-apri-alaska @Patrick-Daly-AA @chrisfalaska