Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename element type #1

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Rename element type #1

merged 2 commits into from
Nov 6, 2020

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 6, 2020

Rename element_type into name

This attribute has been renamed by the alchemy-json_api gem
and reflects what this attribute is called in Alchemy core.

Rename elementType() into componentName()

The element attribute used is called name and not type, also in Vue components have a name attribute.

This attribute has been renamed by the alchemy-json_api gem
and reflects what this attribute is called in Alchemy core.
The element attribute used is called name and not type, also
in Vue components have a name attribute.
@tvdeyen tvdeyen requested a review from mamhoff November 6, 2020 14:37
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's still a reference to element_type in the wiki as well?

@tvdeyen
Copy link
Member Author

tvdeyen commented Nov 6, 2020

I think there's still a reference to element_type in the wiki as well?

In our private company wiki? Yes, but not here :)

@tvdeyen tvdeyen merged commit a4a817b into main Nov 6, 2020
@tvdeyen tvdeyen deleted the rename-element_type branch November 6, 2020 15:43
@tvdeyen tvdeyen restored the rename-element_type branch November 6, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants