Changed outcome to represent databallpy_events #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alek050
added
the
Refactor
DaanGro
approved these changes
Aug 17, 2023
Alek050
added a commit
that referenced
this pull request
Sep 20, 2023
* Added to all event data providers (#115) * Changed outcome to represent databallpy_events (#121) * Created base event class (#122) * Created initial ShotEvent class with information from opta (#123) * Added first shot class * Added ShotEvent class with initial event information of shots from Opta * with added new files * Added requested changes * linters * Added tracking data features to shot events, dribble class, individual player poessions, and changed the synchronise cost function (#124) * Added first shot class * Added ShotEvent class with initial event information of shots from Opta * with added new files * Added requested changes * linters * Added tracking data features to shots * Added calculations to obtain invdividual player posession * Added dribble event and changed synchronise cost function * Added doccstrings * refacted angle * linter * Created pass class (#126) * Changed base event class * Added first shot class * Added PassEvent class * added tests * fixed some bugs and add passes to match --------- Co-authored-by: Daan <daaniogrob@gmail.com> * I'm sorry this PR is too big (#133) * I'm sorry this pr is too big * add forgotten docstring * linters * Added databallpy_events to metrica (#134) * Added databallpy_events to metrica * added extra tests for metrica databallpy events --------- Co-authored-by: Daan Grob <91313814+DaanGro@users.noreply.github.com> Co-authored-by: Daan <daaniogrob@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #116