Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new variables to fit with Sci V2 #189

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Added new variables to fit with Sci V2 #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
993b2cd
Added possibility to load event data without metadata
Alek050 Jan 17, 2024
e836602
Changes
Alek050 Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion databallpy/data_parsers/event_data_parsers/scisports_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@
"Shot Wide": "shot",
"Shot on Target": "shot",
"Shot Goal": "shot",
"Own Goal": "shot",
"Goal": "shot",
"Own Goal": "own_goal",
"Take On": "dribble",
}

Expand Down Expand Up @@ -590,6 +591,7 @@ def _get_shot_instances(event_data: pd.DataFrame) -> dict:
"Shot Wide": "miss_off_target",
"Own Goal": "own_goal",
"Shot": "not_specified",
"Goal": "goal",
}
shots_mask = event_data["databallpy_event"] == "shot"
shot_events = {}
Expand Down
10 changes: 6 additions & 4 deletions databallpy/get_match.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ def get_match(
"metrica": True,
"instat": False,
"ortec": True,
"scisports": True,
}

LOGGER.info(
Expand Down Expand Up @@ -214,10 +215,11 @@ def get_match(
)
else:
extra_data = None
home_players = event_metadata.home_players
away_players = event_metadata.away_players
periods = event_metadata.periods_frames
pitch_dimensions = event_metadata.pitch_dimensions
if uses_event_metadata:
home_players = event_metadata.home_players
away_players = event_metadata.away_players
periods = event_metadata.periods_frames
pitch_dimensions = event_metadata.pitch_dimensions

# extra checks when using tracking data
if uses_tracking_data:
Expand Down
Loading