[Optimize] Further blocking tweaks #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joske
approved these changes
Mar 4, 2024
|
@vicsn @onetrickwolf @iamalwaysuncomfortable We will need to validate this branch with at least 12 hours of burn-in prior to approvals. |
|
I'll fix the |
…rker Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
ljedrz
force-pushed
the
perf/further_blocking
branch
from
0dfccdb to
b1b3485
Compare
|
Double-clicking on this. @vicsn @onetrickwolf @iamalwaysuncomfortable Did we get a chance to burn-in test this change? |
|
@vicsn @onetrickwolf @iamalwaysuncomfortable When will this be addressed? |
|
Starting to test this now |
howardwu
approved these changes
Mar 13, 2024
Looks good. Ran for 12+ hours with 1.6 TPS and 3 seconds/block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves 2 additional potentially blocking operations into blocking tasks; they were found to be significant using
tokio-console, which was also used to double-check that these changes decrease theBusytime of the associated tasks.