Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add network ID support to devnet scripts #3296

Merged
merged 1 commit into from
Jun 11, 2024
Merged

[Feature] Add network ID support to devnet scripts #3296

merged 1 commit into from
Jun 11, 2024

Conversation

vicsn
Copy link
Contributor

@vicsn vicsn commented Jun 7, 2024

Motivation

Reintroduces #3262

Which was reverted

Test Plan

It is not influenced by CI

Related PRs

We had a temporary Mirror here: ProvableHQ#12

gluax
gluax approved these changes Jun 11, 2024
View reviewed changes
Copy link

@gluax gluax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense to me.

I do wish we could consider an endpoint /api/v1/network(or something equivalent) that would return the current networks name though.

@zosorock zosorock merged commit c3078a1 into AleoNet:mainnet-staging Jun 11, 2024
0 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gluax gluax gluax approved these changes

@Meshiest Meshiest Meshiest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vicsn @Meshiest @gluax @zosorock