Spam connections and forged block locators fix #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update/mainnet staging
ljedrz
reviewed
Oct 25, 2024
ljedrz
reviewed
Oct 25, 2024
ljedrz
reviewed
Oct 25, 2024
ljedrz
reviewed
Oct 25, 2024
ljedrz
reviewed
Oct 25, 2024
ljedrz
reviewed
Oct 25, 2024
ljedrz
reviewed
Oct 25, 2024
Pjrich1313
suggested changes
Oct 28, 2024
zosorock
requested review from
ljedrz,
damons,
lukenewman,
niklaslong,
asharma13524,
fulltimemike and
a team
vicsn
approved these changes
Oct 31, 2024
howardwu
reviewed
Nov 1, 2024
howardwu
reviewed
Nov 1, 2024
howardwu
reviewed
Nov 1, 2024
howardwu
reviewed
Nov 1, 2024
zkxuerb
added
Mid Priority
This was referenced Nov 15, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The motivation behind this PR is to have a mechanism of banning peer IPs as outlined here to mitigate cases that might stall client/validators.
Approach
A banned peers list was implemented to store peers acting maliciously that are banned for 300 seconds. If a peer sends more than 10 connection requests in under 10 seconds they get banned and if a peer does not respond to block requests within 600 seconds ( can be changed ) they get banned.
Test Plan
This was tested on an isolated network with a different ip/machine per peer. Plan is to test this out on the Canary network with the relevant attacks.
Related PRs
#3366
#3388