-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZKS-05] Caller Is Not Fixed Throughout Function Execution #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsn
force-pushed
the
commit_self_caller
branch
from
October 23, 2023 06:35
a5b2d57
to
b167726
Compare
…k to make scm hiding.
vicsn
force-pushed
the
commit_self_caller
branch
from
January 5, 2024 11:26
b167726
to
ce4ea93
Compare
- request::verify::tests::test_sign_and_verify_* - tests::test_credits::sanity_checks::test_sanity_check_*
vicsn
force-pushed
the
commit_self_caller
branch
from
January 5, 2024 16:32
5a7c52a
to
47c24c3
Compare
howardwu
reviewed
Jan 21, 2024
howardwu
reviewed
Jan 21, 2024
howardwu
reviewed
Jan 21, 2024
howardwu
reviewed
Jan 21, 2024
howardwu
reviewed
Jan 21, 2024
howardwu
reviewed
Jan 21, 2024
howardwu
reviewed
Jan 21, 2024
howardwu
reviewed
Jan 21, 2024
howardwu
reviewed
Jan 21, 2024
howardwu
reviewed
Jan 21, 2024
howardwu
reviewed
Jan 21, 2024
howardwu
reviewed
Jan 21, 2024
howardwu
reviewed
Jan 21, 2024
raychu86
reviewed
Jan 21, 2024
raychu86
reviewed
Jan 21, 2024
raychu86
changed the title
[zksecurity 05] Caller Is Not Fixed Throughout Function Execution
[ZKS-05] Caller Is Not Fixed Throughout Function Execution
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should ensure the self.signer is the same throughout a call graph in a single Execution.
As recommended, this PR adds binding and hiding commitments to the signer in each transition, which needs a secret which is constant for the entire execution. We propose the following, which will leak the signer to everyone holding the root_tvk:
signer_commitment = hash(signer address || root_tvk)
Notes:
Execution
Test Plan
./resources/block.genesis