-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NCC-Y7H] Create compute_function_id helper which enforces minimal TLV encoding #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsn
force-pushed
the
function_id_tlv_encoding
branch
from
November 6, 2023 11:19
e0e368d
to
b9abacc
Compare
howardwu
reviewed
Jan 9, 2024
Signed-off-by: Howard Wu <9260812+howardwu@users.noreply.github.com>
howardwu
reviewed
Jan 9, 2024
Signed-off-by: Howard Wu <9260812+howardwu@users.noreply.github.com>
howardwu
reviewed
Jan 9, 2024
Signed-off-by: Howard Wu <9260812+howardwu@users.noreply.github.com>
howardwu
reviewed
Jan 9, 2024
Signed-off-by: Howard Wu <9260812+howardwu@users.noreply.github.com>
howardwu
reviewed
Jan 9, 2024
Signed-off-by: Howard Wu <9260812+howardwu@users.noreply.github.com>
raychu86
changed the title
[NCC Y7H] Create compute_function_id helper which enforces minimal TLV encoding
[NCC-Y7H] Create compute_function_id helper which enforces minimal TLV encoding
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As defense in depth, in case we allow custom program_id's in the future, it is good practice to encode the length of each input. Some implementation notes:
A::hash
which would warrant an extra TLV encoding. There might be a problem if end-users hash containers themselves (in Leo or Aleo instructions), but then it is up to them to implement TLV encoding.program/id
folder toprogram/program_id
to distinguish it fromprogram/function_id
.Test Plan
I did not add more tests.