-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZKS-04] Track committee size. #2213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardwu
reviewed
Dec 18, 2023
Signed-off-by: Howard Wu <9260812+howardwu@users.noreply.github.com>
Hi, I recently submitted a bug report (id: 2289066) at HackerOne that is directly related to the committee update. The report shows that updating the committee at every block will cause some consensus issues. I suggest to review the report and take it into consideration. |
Hi @randomsleep thank you for the extra heads up. Just FYI we've seen the issue, great finding, we will circle back on HackerOne. |
howardwu
approved these changes
Feb 9, 2024
raychu86
changed the title
[Feature] Track committee size.
[Feature] [zksecurity 04] Track committee size.
Feb 12, 2024
raychu86
changed the title
[Feature] [zksecurity 04] Track committee size.
[zksecurity 04] Track committee size.
Feb 12, 2024
raychu86
changed the title
[zksecurity 04] Track committee size.
[ZKS-04] Track committee size.
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
metadata
mapping.200
.100_000
.The benches/rewards branch measures the performance of
atomic_post_ratify
for various numbers of delegators distributed uniformly over 200 validators.On a 2021 M1 MAX:
Using memory based storage, we found:
Helps with addressing Audit Finding: [zksecurity 04] Garbage Collection Can Block Commits From Happening