[NCC-ADN] Prevent ignoring proving/verifying tasks #2 #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljedrz
reviewed
Jan 9, 2024
ljedrz
approved these changes
Jan 9, 2024
howardwu
reviewed
Jan 11, 2024
Signed-off-by: Howard Wu <9260812+howardwu@users.noreply.github.com>
howardwu
reviewed
Jan 11, 2024
Signed-off-by: Howard Wu <9260812+howardwu@users.noreply.github.com>
howardwu
reviewed
Jan 11, 2024
Signed-off-by: Howard Wu <9260812+howardwu@users.noreply.github.com>
howardwu
reviewed
Jan 11, 2024
Signed-off-by: Howard Wu <9260812+howardwu@users.noreply.github.com>
howardwu
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cleanup based on NCC's finding, we should make sure that we don't silently ignore proving/verifying tasks.
Test Plan
No new tests were added because the current codebase would not have triggered this issue anyway, it is defense in depth.
Related PRs
Successor to: https://github.com/AleoHQ/snarkVM/pull/2032 which had a bunch of unrelated and unclear changes.