[ZKS-02] Introduce committee lookback #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raychu86
commented
Feb 10, 2024
| @@ -82,11 +82,24 @@ impl<N: Network, C: ConsensusStorage<N>> Ledger<N, C> { | |||
| let ratified_finalize_operations = | |||
| self.vm.check_speculate(state, block.ratifications(), block.solutions(), block.transactions())?; | |||
|
|
|||
| // Get the round number for the previous committee. Note, we subtract 2 from odd rounds, | |||
| // because committees are updated in even rounds. | |||
| let previous_round = match block.round() % 2 == 0 { | |||
There was a problem hiding this comment.
Technically, we can just subtract 1, because block rounds are always even.
howardwu
approved these changes
Feb 10, 2024
raychu86
changed the title
raychu86
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR introduces a committee round lag of 100 rounds to match the
MAX_GC_ROUNDS. This committee round lag is used in consensus to ensure that the committee being used to validate the subdags is the committee atround.saturating_sub(N::COMMITTEE_ROUND_LAG).Audit Finding: [zksecurity 02] Dynamic Committee Feature is Not Safe