Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup UpdateKeyValue and RemoveKeyValue finalize operations #2348

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Cleanup UpdateKeyValue and RemoveKeyValue finalize operations #2348

merged 4 commits into from
Feb 12, 2024

Conversation

raychu86
Copy link
Contributor

@raychu86 raychu86 commented Feb 12, 2024 •
edited
Loading

Motivation

This PR removes the unused index variable in the UpdateKeyValue finalize operation and replaces the index variable in the RemoveKeyValue finalize operation with the key_id.

@raychu86 raychu86 changed the title Cleanup FinalizeOperation::UpdateKeyValue Cleanup UpdateKeyValue and RemoveKeyValue finalize operations Feb 12, 2024
@howardwu howardwu merged commit 1bfe459 into mainnet Feb 12, 2024
78 checks passed
@howardwu howardwu deleted the feat/cleanup-finalize-operations branch February 12, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardwu howardwu howardwu approved these changes

Assignees
No one assigned
Labels
mainnet-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raychu86 @howardwu