[ZKS-02] Use committee lookback at anchor_round - 1 for timestamp calculation
#2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raychu86
force-pushed
the
feat/timestamp-committee
branch
from
ad748ac to
bbd466f
Compare
howardwu
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is a continuation of https://github.com/AleoHQ/snarkVM/pull/2353, and fixes the committee usage for timestamp calculation. Previously, we were selecting the committee lookback based on the anchor round, however we should have been using the committee lookback based on
anchor_round - 1.This is needed because the timestamp is calculated with the weighted median using certificates in
anchor_round - 1for the committed subdag. Note that the previous approach was not an issue with static committees, however with more complex bond/unbond state, it was insufficient.Audit Finding: [zksecurity 02] Dynamic Committee Feature is Not Safe