Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add impl Ternary for Box<T: Ternary> #2362

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add impl Ternary for Box<T: Ternary> #2362

merged 1 commit into from
Feb 20, 2024

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Feb 19, 2024

Motivation

Reduce the amount of boilerplate code

@kpp kpp force-pushed the ternary_impl_box branch from b40c9c5 to 7b42092 Compare February 19, 2024 09:14
@howardwu howardwu requested a review from ljedrz February 19, 2024 23:56
ljedrz
ljedrz approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍; there is likely more potential for improvements like this one.

@howardwu howardwu merged commit 0f9e500 into AleoNet:mainnet Feb 20, 2024
78 checks passed
@kpp kpp deleted the ternary_impl_box branch February 21, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljedrz ljedrz ljedrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpp @ljedrz @howardwu