[HackerOne-2332566] Unify target calculations #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardwu
approved these changes
Apr 2, 2024
Base automatically changed from
update/is-coinbase-target-is-met
to
mainnet-staging
April 2, 2024 16:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR unifies the target calculations in both
Ledger::construct_block_templateandBlock::verify_solutionsinto a singularto_next_targetshelper method. Previously the two implementations were disjoint and could lead to differences in expected value. The unified helper method reduces the possibility of error and makes it easier to update if there are changes in the future.Test Plan
The use of a helper method also allows us to test the expected behavior outside the monolith of block production. Tests have been added to check that the expected values based on hitting/missing the target threshold are correct.
This PR is based on and merges into https://github.com/AleoHQ/snarkVM/pull/2410.