[Log] Changes to epoch hash. #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raychu86
reviewed
Apr 3, 2024
raychu86
reviewed
Apr 3, 2024
howardwu
reviewed
Apr 3, 2024
howardwu
reviewed
Apr 3, 2024
Co-authored-by: Howard Wu <9260812+howardwu@users.noreply.github.com> Signed-off-by: d0cd <23022326+d0cd@users.noreply.github.com>
Co-authored-by: Howard Wu <9260812+howardwu@users.noreply.github.com> Signed-off-by: d0cd <23022326+d0cd@users.noreply.github.com>
|
^CI is failing |
howardwu
reviewed
Apr 3, 2024
ledger/src/advance.rs
Outdated
Comment on lines
107
to
110
| // Get the height of the block. | ||
| let height = block.height(); | ||
| // Get the epoch hash for the block. | ||
| let epoch_hash = &self.get_epoch_hash(height).ok(); |
howardwu
reviewed
Apr 3, 2024
ledger/src/advance.rs
Outdated
| // Update the current epoch hash. | ||
| self.current_epoch_hash.write().clone_from(&self.get_epoch_hash(block.height()).ok()); | ||
| self.current_epoch_hash.write().clone_from(epoch_hash); |
There was a problem hiding this comment.
You can move this into L114
howardwu
reviewed
Apr 3, 2024
ledger/src/advance.rs
Outdated
| // Get the epoch hash for the block. | ||
| let epoch_hash = &self.get_epoch_hash(height).ok(); | ||
| // Log the update of the current epoch hash. | ||
| match epoch_hash { |
There was a problem hiding this comment.
You can move the one-line to this match statement
howardwu
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR logs changes to the
current_epoch_hashin theLedger.