Introduce large execution transaction test helper #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this target #2437? |
|
One way we can dedup is by adding a helper in |
It can, I wanted to avoid adding overhead to your changeset by pointing it that way but happy to do what is most convenient for you. |
|
I've done a little deduping, I'm not super familiar with this code so lmk if I missed something or named something poorly 🙏 |
|
Deduping looks good! Happy to merge this in to #2437 to consolidate the final review. |
niklaslong
force-pushed
the
feat/transaction-byte-limit
branch
from
be373c9 to
bcc7e27
Compare
|
Rebased after the latest merges into |
niklaslong
requested review from
d0cd and
howardwu
and removed request for
d0cd
howardwu
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #2437, only the last commit is new. Introduces a test helper for a large execution transaction to it can be used in the snarkOS codec tests.
Todo: check if worth deduplicating withDone.synthesizer/src/vm/mod.rstests.