Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOB] Fix length in Serialize impl for Transition #2440

Merged
merged 1 commit into from
Apr 24, 2024
Merged

[TOB] Fix length in Serialize impl for Transition #2440

merged 1 commit into from
Apr 24, 2024

Conversation

d0cd
Copy link
Contributor

@d0cd d0cd commented Apr 22, 2024

Motivation

This PR fixes the Serialize implementation for Transitions by correcting the number of struct fields.

Finding: TOB-PUZZLE-3

raychu86
raychu86 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@raychu86 raychu86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In the future, we may want to integrate semgrep checks to CI to prevent future instances of this case.

@howardwu howardwu merged commit 8b7f59e into mainnet-staging Apr 24, 2024
80 checks passed
@howardwu howardwu deleted the fix/transition-serialization branch April 24, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raychu86 raychu86 raychu86 approved these changes

@howardwu howardwu howardwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d0cd @howardwu @raychu86