Adds a variable limit for deployments #2444
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Note: This PR contains breaking changes. First, all verifying keys are serialized with 8 extra bytes to account for the
num_variables
, which represents the number of constant, public, and private variables in the circuit. In addition, theDataID
was updated to address an openTODO
which involves reordering the map IDs (and also a breaking change).Original motivation from @vicsn :
Test Plan
Adding two tests, one testing the variable limit, and one testing manipulation of reported variables.
Related PRs
Supersedes #2431.
Similar to: https://github.com/AleoHQ/snarkVM/pull/2271.