Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Update documentation in atomic_speculate #2472

Merged
merged 4 commits into from
Nov 14, 2024
Merged

[Chore] Update documentation in atomic_speculate #2472

merged 4 commits into from
Nov 14, 2024

Conversation

byod8
Copy link
Contributor

@byod8 byod8 commented May 30, 2024

Motivation

It's possible that a split transaction have no fee. So this is not a foundational bug we need to abort the transaction here.

iamalwaysuncomfortable
iamalwaysuncomfortable suggested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@iamalwaysuncomfortable iamalwaysuncomfortable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the community contribution! However, this PR avoids the original safety mechanism entirely. I've left comments about how to modify the original approach to ensure the original safety mechanism is left in place.

synthesizer/src/vm/finalize.rs Outdated Show resolved Hide resolved
@vicsn vicsn added the requires-ledger-reset Merging this PR will require a ledger reset label Jun 3, 2024
@zosorock zosorock requested a review from a team June 7, 2024 23:33
@byod8 byod8 requested a review from vicsn June 11, 2024 01:27
@vicsn vicsn removed the requires-ledger-reset Merging this PR will require a ledger reset label Jun 11, 2024
@byod8
Copy link
Contributor Author

byod8 commented Jun 14, 2024

Hi @iamalwaysuncomfortable, please review.

@raychu86 raychu86 changed the title fix: abort the failed Execution without a fee [Chore] Update documentation in atomic_speculate Jul 3, 2024
@zosorock zosorock removed the request for review from iamalwaysuncomfortable November 14, 2024 17:06
@zosorock zosorock added documentation Improvements or additions to documentation v1.2.1 Canary release v1.2.1 labels Nov 14, 2024
@zosorock zosorock merged commit 714e9c3 into AleoNet:staging Nov 14, 2024
0 of 83 checks passed
@zosorock zosorock mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamalwaysuncomfortable iamalwaysuncomfortable iamalwaysuncomfortable requested changes

@vicsn vicsn vicsn approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation v1.2.1 Canary release v1.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@byod8 @vicsn @iamalwaysuncomfortable @zosorock